This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
make: Change make install to build snap #1094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change `make install` also to build snap before `cp`, by adding the command for executing `make all`. Tested manually. Signed-off-by: Saija Sorsa <saija.sorsa@intel.com>
|
Any reason to merge these steps? since make is typically: |
|
I think this is a great idea, @nanliu; with this change the Snap build process would match what I expected |
|
LGTM |
|
👍 for a merge from me too |
|
w/ the LGTMs, I'm merging. Thanks @ssorsa for your contribution! |
nanliu
added a commit
that referenced
this pull request
Aug 12, 2016
make: Change 'make install' NOT to build Snap. Revert of #1094
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX
Summary of changes:
make installto include building of snap beforecpTesting done:
@intelsdi-x/snap-maintainers
Change
make installalso to build snap beforecp, by adding the command forexecuting
make all. Tested manually.Signed-off-by: Saija Sorsa saija.sorsa@intel.com