Fixes #1118 - Getting started guide fails? #1122
Conversation
Sets the current time as the advertised time in the returned metric when using grpc.
| var lastAdvertisedTime time.Time | ||
| // if the lastAdvertisedTime is not set we handle. -62135596800 represents the | ||
| // number of seconds from 0001-1970 and is the default value for time.Unix. | ||
| if mt.LastAdvertisedTime.Sec == int64(-62135596800) { |
There was a problem hiding this comment.
This is quite unexpected to have time replaced by Now() during conversion.
There was a problem hiding this comment.
This is due to timezone switch to LMT (not sure the exact cut off dates). Maybe another option is to only log in UTC?
$ go_time
t: 1900-01-01 00:00:00 +0000 UTC t in Local: 1899-12-31 16:07:02 -0752 LMT
t2: 2000-01-01 00:00:00 +0000 UTC t2 in Local: 1999-12-31 16:00:00 -0800 PST
There was a problem hiding this comment.
Wow, good catch @nanliu . I haven't been aware of that some places in the world (maybe Poland too, gotta check) had in the past different and fractional "time zone" ...and PCs actually take this into account 💯
We have some today, so I assumed author of the issue just lives in unlucky place that crashes Go ✌️ Fortunately they are fractional only in terms of hours and this function is crashing on fractional minutes.
|
I guess that this issue is caused by fractional timezone set when unmarshalling data from grpc (by calling |
|
LGTM |
Fixes #1118
Sets the current time as the advertised time in the returned metric when using grpc.
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers