Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Update GLOSSARY.md #1371

Merged
merged 2 commits into from Nov 22, 2016
Merged

Update GLOSSARY.md #1371

merged 2 commits into from Nov 22, 2016

Conversation

ghost
Copy link

@ghost ghost commented Nov 22, 2016

Summary of changes:

  • Fixed typos
  • Updated glossary terminology using snapctl and snapd to snaptel and snapteld, respectively
  • Updated hyperlinks using snapctl and snapd to snaptel and snapteld, respectively

Testing done:

  • Tested all hyperlinks

@intelsdi-x/snap-maintainers

Updated glossary terminology and hyperlinks using snapctl and snapd to snaptel and snapteld, respectively.
@@ -71,10 +71,10 @@ Snap is simple in scope and it becomes more simple when you know the terminology
### Snap Telemetry
* The full name of the Snap project, used mostly for easy searching (like snap-telemetry.io) or hashtag (#SnapTelemetry)

### `snapctl`
### snaptel
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you intentionally remove grave accent?

* The command-line interface (CLI) for Snap, released as a [binary][binary]

### `snapd`
### snapteld
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question

@IRCody
Copy link
Contributor

IRCody commented Nov 22, 2016

Can we make this one commit? Other than that LGTM.

@kindermoumoute kindermoumoute merged commit 8c86419 into intelsdi-x:master Nov 22, 2016
@mbbroberg
Copy link
Contributor

@IRCody as maintainers, we can do that ourselves as of the latest GitHub release 👍

merge-and-squash

@IRCody
Copy link
Contributor

IRCody commented Nov 22, 2016

@mjbrender: Doesn't that result in not having a merge commit?

@mbbroberg
Copy link
Contributor

mbbroberg commented Nov 22, 2016

@IRCody: good call - I was wrong. If we're staying consistent with merge commits, we shouldn't use that feature 😞 cc @kindermoumoute

(Didn't mean to tag you @obourdon)

@kindermoumoute
Copy link
Contributor

@mjbrender: Doesn't that result in not having a merge commit?

Is it really bad not to have this merge commit?

@mbbroberg
Copy link
Contributor

@kindermoumoute it's not a big deal to miss it this time, but we have stuck to using them and should remain consistent.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants