Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fixes #1450 - check publish response for error #1451

Merged
merged 2 commits into from
Dec 23, 2016

Conversation

jcooklin
Copy link
Collaborator

@jcooklin jcooklin commented Dec 23, 2016

Fixes #1450

Summary of changes:

  • checks publish response (grpc client) for an error

after

related: intelsdi-x/snap-plugin-lib-go#54
@intelsdi-x/snap-maintainers

Copy link
Contributor

@IRCody IRCody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It doesn't seem to depend on the change in the lib afaict. Is that correct?

@@ -457,8 +455,7 @@ func (ap *availablePlugins) publishMetrics(metrics []core.Metric, pluginName str

p, err := pool.SelectAP(taskID, config)
if err != nil {
errs = append(errs, err)
return errs
return []error{serr}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is it []error{err}?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, I didn't notice that!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@candysmurf how does it look now?

@jcooklin
Copy link
Collaborator Author

LGTM. It doesn't seem to depend on the change in the lib afaict. Is that correct?

Correct.

@candysmurf candysmurf merged commit 15bb174 into intelsdi-x:master Dec 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants