This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Adding timeout setting to snaptel #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@iwankgb: The build error seems to be related to gofmt. Did you run gofmt on the commit? |
iwankgb
force-pushed
the
timeout_in_snaptel
branch
from
e425203 to
2a99b4b
Compare
|
@IRCody - it looks that I have not. Should pass now. |
|
@iwankgb you have to run go imports too. |
iwankgb
force-pushed
the
timeout_in_snaptel
branch
2 times, most recently
from
b85c44b to
bd290fb
Compare
|
@kindermoumoute, @IRCody - it seems that I managed to come to terms with formatting. Finally... ;) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes lack of support for #1487 in Snap CLI client.
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers