Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fixes #1438, set standard logger as logger for grpc #1543

Merged
merged 1 commit into from
Mar 7, 2017

Conversation

katarzyna-z
Copy link
Contributor

@katarzyna-z katarzyna-z commented Mar 6, 2017

Fixes #1438

Summary of changes:

  • Set standard logger as logger for grpc, logs from grpc depend on log level set for snapteld

Now user will see noisy logs from grpc only for log level set to DEBUG and INFO, logs will be visible in following form:

INFO[0015] transport: http2Client.notifyError got notified that the client transport was broken read tcp 127.0.0.1:57370->127.0.0.1:43376: read: connection reset by peer. 
INFO[0015] grpc: addrConn.resetTransport failed to create client transport: connection error: desc = "transport: dial tcp 127.0.0.1:43376: operation was canceled"; Reconnecting to {"127.0.0.1:43376" <nil>} 
INFO[0015] grpc: addrConn.transportMonitor exits due to: grpc: the connection is closing 

Testing done:

  • small, medium tests

@intelsdi-x/snap-maintainers

@katarzyna-z katarzyna-z force-pushed the grpc-logs branch 3 times, most recently from e1de62d to 6542d89 Compare March 6, 2017 15:28
@katarzyna-z katarzyna-z changed the title Fixes #1438, set log level for logs from grpc to user defined Fixes #1438, set standard logger as logger for grpc Mar 6, 2017
Copy link
Collaborator

@jcooklin jcooklin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@katarzyna-z katarzyna-z merged commit 58fb94c into intelsdi-x:master Mar 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants