This repository has been archived by the owner on Nov 8, 2022. It is now read-only.
Added 32-bit build #1563
Merged
Added 32-bit build #1563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need a 32-bit build for customers running antiquated hardware. I opened an issue to track this change here: intelsdi-x#1562
jcooklin
suggested changes
Mar 20, 2017
scripts/build_all.sh
Outdated
| @@ -24,5 +24,9 @@ export GOARCH=amd64 | |||
| "${__dir}/build_snap.sh" & | |||
| "${__dir}/build_plugins.sh" & | |||
|
|
|||
| export GOOS=windows32 | |||
There was a problem hiding this comment.
This needs to be GOOS=windows
There was a problem hiding this comment.
Doesn't that conflict with the earlier declaration of GOOS=windows?
Apologies, thought the GOOS had to be unique
jcooklin
approved these changes
Mar 21, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need a 32-bit build for customers running antiquated hardware. I opened an issue to track this change here: #1562
Fixes #
Summary of changes:
Testing done:
@intelsdi-x/snap-maintainers