Skip to content
This repository has been archived by the owner on Nov 8, 2022. It is now read-only.

Fixes #820 - Task fails when metrics come from different versions of … #822

Merged
merged 1 commit into from
Apr 1, 2016

Conversation

jcooklin
Copy link
Collaborator

Fixes # 820

Summary of changes:

  • Fixes issue where we override the plugin for a given metric

Testing done:

  • Updated workflow test to cover this case
  • Manual

Scenario:

  • Start snap and load 2 different versions of the same plugin
    • The lesser version should contain a metric that is not available in the new version
  • Load a task that retrieves a metric that is only available in the older plugin

Snapd config which causes /intel/mock/test to become available:


---
control:
  plugins:
    collector:
      mock:
        versions:
          1:
            test: true

Task definition:


---
  version: 1
  schedule:
    type: "simple"
    interval: "1s"
  workflow:
    collect:
      metrics:
        /intel/mock/bar: {}
        /intel/mock/foo: {}
        /intel/mock/test: {}
      config:
        /intel/mock:
          user: "root"
          password: "secret"

Before:
before
After:
after

@intelsdi-x/snap-maintainers

@candysmurf
Copy link
Contributor

LGTM

@jcooklin jcooklin merged commit d6f07fa into intelsdi-x:master Apr 1, 2016
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants