fix: fixes from single ffprobe command #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
francescov1
changed the title
francescov1
commented
Sep 20, 2022
| @@ -225,6 +232,14 @@ func getAudioCodec(inputFilePath: String) -> AudioCodec { | |||
| return convertToAudioCodec(inputCodec: codec) | |||
| } | |||
|
|
|||
| func getVideoCodecTag(inputFilePath: String) -> String { | |||
There was a problem hiding this comment.
Note this adds another async ffprobe command, but we will be removing all these extra sync ffprobe commands once #54 is merged
revblaze
approved these changes
Sep 20, 2022
.gitignore
Outdated
Comment on lines
52
to
54
| Converter.xcworkspace/xcuserdata/francescovirga.xcuserdatad/UserInterfaceState.xcuserstate | ||
| Converter.xcworkspace/xcuserdata/justinbush.xcuserdatad/UserInterfaceState.xcuserstate |
There was a problem hiding this comment.
I think that we can actually just add xcuserdata/ as whole, per line 41 of the suggested gitignore.
There was a problem hiding this comment.
Everything in this directory is specific to our own Xcode setups
There was a problem hiding this comment.
Kk sounds good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the video conversion fixes from #54 to main, since our man Taner is salty and we don't know when https://github.com/tanersener/ffmpeg-kit/issues/571 will be fixed 😉