Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: support aarch64 builds #306

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

waveywaves
Copy link
Contributor

update github actions workflows and goreleaser to support aarch64.

Summary

Add aarch64 build and goreleaser support


Related issue :
fixes #305

@dciangot dciangot self-requested a review October 22, 2024 06:51
Copy link
Collaborator

@dciangot dciangot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dciangot
Copy link
Collaborator

hi @waveywaves thanks for this PR.. can I ask you just one small amed signin your commit? git commit --amend --signoff should be enough

update github actions workflows and goreleaser to support aarch64.

Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
@waveywaves
Copy link
Contributor Author

image
hey diego, the commit was already signed off but I signed it and committed again

@dciangot
Copy link
Collaborator

mmm, weird, is not picking it up in the check... never mind, I'll merge it anyway, sorry for the noise

@dciangot dciangot merged commit 676fee7 into interTwin-eu:main Oct 22, 2024
3 of 4 checks passed
@waveywaves
Copy link
Contributor Author

waveywaves commented Oct 22, 2024

@dciangot might be a gpg key issue on my end, checking, hopefully in commits going ahead I won't have this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI: Support aarch64 build
2 participants