Fix figure labels in docs/Cookbook scenarios tabs #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix swapped figures "Edge" <-> "In-cluster" in Cookbook scenarios tabs
|
Oops... actually a good check @chbrandt ! But I suspect the correct fix to be on inverting the description in the introduction part. The naming there is inverted ideed. The "in-cluster" is the one with all the components running in the cluster |
Fix the scenarios X figures
This reverts commit d8c7714.
|
Got it. Reverted the previous modifications (to Cookbook) and fixed the figures in Intro. |
|
IMHO that I find the term "In-cluster" confusing as there are clusters on both sides (K8S, HPC). Previously, I had understood "in-cluster" was referring to interLink API being located inside "their" cluster... |
|
Merged, thanks @chbrandt!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix swapped figures labels "Edge" <-> "In-cluster" in Cookbook scenarios tabs
Summary
Swap the labels associated to scenario-1 (In-cluster) and scenario-2 (Edge) figures in Cookbook
Related issue :
na