Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Remove unused pytest plugin #1377

Merged
merged 2 commits into from
May 2, 2023
Merged

tests: Remove unused pytest plugin #1377

merged 2 commits into from
May 2, 2023

Conversation

silasary
Copy link
Member

@silasary silasary commented May 2, 2023

Pull Request Type

  • Feature addition
  • Bugfix
  • Documentation update
  • Code refactor
  • Tests improvement
  • CI/CD pipeline enhancement
  • Other: [Replace with a description]

Description

Tests are currently failing on CI due to kevin1024/vcrpy#688. As we never actually ended up using it in any of our tests, I'm just going to remove the plugin from the test environment entirely.

Changes

Remove Unused plugin from [tests] extra dependencies.

Related Issues

Test Scenarios

Python Compatibility

  • I've ensured my code works on Python 3.10.x
  • I've ensured my code works on Python 3.11.x

Checklist

  • I've run the pre-commit code linter over all edited files
  • I've tested my changes on supported Python versions
  • I've added tests for my code, if applicable
  • I've updated / added documentation, where applicable

@codecov-commenter
Copy link

codecov-commenter commented May 2, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (fc86e3b) 47.52% compared to head (6072200) 47.52%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #1377   +/-   ##
=========================================
  Coverage     47.52%   47.52%           
=========================================
  Files           139      139           
  Lines         14540    14540           
=========================================
  Hits           6910     6910           
  Misses         7630     7630           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@LordOfPolls LordOfPolls merged commit c46405b into unstable May 2, 2023
@LordOfPolls LordOfPolls deleted the remove-vcr branch May 2, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants