Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with Intercom pod not being updated / installed when GitHub response was not 200 OK #246

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Fix issue with Intercom pod not being updated / installed when GitHub response was not 200 OK #246

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions intercom-plugin/scripts/checkForUpdate.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,15 +89,15 @@ module.exports = function(context) {
updateInfo.lastCheckDate = Date.now();

if (releaseData != null) {
updateInfo.releaseDate = Date.parse(releaseData['published_at']);
updateIntercomIfNeeded(context, updateInfo, function() {
deferral.resolve();
});
updateInfo.releaseDate = Date.parse(releaseData['published_at']);
} else {
writeUpdateInfo(context, updateInfo, function() {
deferral.resolve();
});
// last release date is unavailable, set it to today so that the pod is installed
updateInfo.releaseDate = Date.now();
}

updateIntercomIfNeeded(context, updateInfo, function() {
deferral.resolve();
});
});
} else {
deferral.resolve();
Expand Down