New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct PHPdoc types for user IDs #201

Merged

brianw merged 2 commits into intercom:master from fnwbr:patch-1

Apr 4, 2017

Contributor

fnwbr commented Feb 22, 2017 •

edited

Loading

IDs are strings, not integers: https://developers.intercom.com/reference#user-model
Also, get() receives the $query parameters as an array, not as a string.

fnwbr added 2 commits

February 22, 2017 16:18


          Use correct PHPdoc types for user IDs

536cdf2


          Use correct type for $query parameter for get() method

8d3d848

Contributor

brianw commented Apr 4, 2017

Sorry for the slow response here 😞 Thank you so much for correcting our PHPdoc.

I'll merge this change now, it'll be included in the next patch release of the client which should be early next week.

brianw merged commit 9ebffdf into intercom:master

fnwbr deleted the patch-1 branch

April 4, 2017 15:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet