Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Type hinting #284

Merged
merged 1 commit into from
Aug 27, 2019
Merged

Type hinting #284

merged 1 commit into from
Aug 27, 2019

Conversation

sylfabre
Copy link
Contributor

Fix #282

@sylfabre sylfabre mentioned this pull request Aug 25, 2019
Closed
GabrielAnca
GabrielAnca approved these changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@GabrielAnca GabrielAnca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for this PR 🙇 I appreciate that you've been so deliberate in only adding the hints to the methods that wouldn't work if the incorrect type is passed and therefore making the change backwards-compatible.

@GabrielAnca GabrielAnca merged commit a01e6b5 into intercom:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielAnca GabrielAnca GabrielAnca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Use type hint for methods
2 participants
@sylfabre @GabrielAnca