fix(CFPlugin): fix CF server detection for CF 2023 Windows service #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to compare this with FR. As I am pretty sure I copied FR to get this. So need to check again how FR is handling this detection. Other than that it looks ok. On mobile ATM so will check it once back in office. |
Umaaz
added
bug
|
Resolved by clone #116 |
|
I checked the FR version, it does seem to handle this case. Not sure why it was changed in Deep. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Prevents NullPointerExceptions occurring when the
sun.java.commandsystem property doesn't exist.Attempts to find the
coldfusion.homesystem property as an additional way to check that Deep is running on a CF server.Which issue(s) this PR fixes:
Fixes #113
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]