Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app frame): fix false positives on app frames #6

Merged
merged 2 commits into from
Nov 1, 2023
Merged

Conversation

Umaaz
Copy link
Member

@Umaaz Umaaz commented Nov 1, 2023

The app frame flag was always being set to true. Should default to false.

@Umaaz Umaaz added the bug Something isn't working label Nov 1, 2023
@Umaaz Umaaz self-assigned this Nov 1, 2023
@Umaaz Umaaz added this to the logging milestone Nov 1, 2023
@Umaaz Umaaz marked this pull request as ready for review November 1, 2023 18:11
@Umaaz Umaaz merged commit 43ee87e into master Nov 1, 2023
7 checks passed
@Umaaz Umaaz deleted the app_frame branch November 1, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant