Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve bigint dependency error in production build #127

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

nud3l
Copy link
Member

@nud3l nud3l commented Jan 19, 2022

The production build for the application was failing due to a BigInt to number conversion issue. This issue is listed here: https://polkadot.js.org/docs/usage/FAQ/#under-my-babel-build-i-have-a-bigint-to-number-conversion-error and was fixed with the approach here: hirosystems/stacks.js#1096 (comment)

@vercel
Copy link

vercel bot commented Jan 19, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/interlay/interbtc-ui/FupER52sHEv4Gtrtj28h9as5cHCa
✅ Preview: https://interbtc-ui-git-dom-fix-bigint-dependency-error-interlay.vercel.app

@github-actions
Copy link

github-actions bot commented Jan 19, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 11
🟢 Accessibility 100
🟢 Best practices 100
🟢 SEO 92
🟠 PWA 75

Lighthouse ran on https://interbtc-ui-git-dom-fix-bigint-dependency-error-interlay.vercel.app/

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4b9aeeb
Status: ✅  Deploy successful!
Preview URL: https://04ce1020.interbtc-ui.pages.dev

View logs

Copy link
Collaborator

@tomjeatt tomjeatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work tracking this down so quickly! Think this is the most obscure bug/fix that I've ever seen :)

@nud3l nud3l merged commit e647030 into master Jan 19, 2022
@crypto-engineer crypto-engineer deleted the dom/fix-bigint-dependency-error branch January 19, 2022 13:44
@crypto-engineer
Copy link
Contributor

Nice work. It should be a really tricky issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants