Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide how nodes will connect to the testnet #260

Closed
gakonst opened this issue Aug 30, 2019 · 3 comments
Closed

Decide how nodes will connect to the testnet #260

gakonst opened this issue Aug 30, 2019 · 3 comments
Labels

Comments

@gakonst
Copy link
Member

gakonst commented Aug 30, 2019

2 options:

  1. support BTP account creation (implement BTP open signup for the Redis store and include that in the node)
  2. pre-load accounts on the testnet nodes

The second is simpler, I think that BTP is mostly understood by @emschwartz only hence could maybe be a lower priority issue

@emschwartz emschwartz mentioned this issue Aug 30, 2019
15 tasks
@emschwartz emschwartz changed the title Decide between BTP Account Creation or Pre-load accounts on testnet Decide how nodes will connect to the testnet Sep 5, 2019
@emschwartz
Copy link
Member

Actually the options are:

  • BTP account creation
  • Expose POST /accounts on testnet nodes to allow new nodes to add themselves (with any parameters)
  • Create a separate signup endpoint that allows new nodes to connect and only set specific parameters (for example, it would not allow them to set the min_balance)
  • Create a website where users could sign up to get testnet credentials, which would call a separate backend service that would insert the new account using POST /accounts
  • Pre-load accounts into the testnet nodes and give out the credentials for the hackathon (only a temporary solution)

@emschwartz
Copy link
Member

I think we should go with:

Create a website where users could sign up to get testnet credentials, which would call a separate backend service that would insert the new account using POST /accounts

This is the one that's most likely to work for the live net and it's pretty simple to go to a website, click "Generate Credentials", and then plug those into your node. It also has the advantage of providing you credentials that you can use to interact with the HTTP API in addition to using BTP and ILP-over-HTTP to send ILP packets. Finally, not trying to create a standard signup API avoids a bunch of bikeshedding over what that should look like and what options are supported.

@emschwartz
Copy link
Member

For now, we've decided to implement the website "generate credentials" option.

@kincaidoneil had an idea for an OAuth-based signup that we may want to use later but we can document that in another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants