Make .mds testable
#303
Merged
Make .mds testable
#303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dora-gt
force-pushed
the
feature/dx/testable-md
branch
from
6d28361
to
1b978ad
Compare
gakonst
approved these changes
Sep 16, 2019
scripts/run-md-tests/README.md
Outdated
| @@ -0,0 +1,9 @@ | |||
| ## Tests for Runnable Markdowns | |||
|
|
|||
| Should implement `hook_before_kill` function like: | |||
emschwartz
requested changes
Sep 17, 2019
dora-gt
force-pushed
the
feature/dx/testable-md
branch
2 times, most recently
from
8f7ae52
to
67db0ef
Compare
emschwartz
approved these changes
Sep 17, 2019
Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>
Merged tests into the original markdowns. Also fixed to add all the directories in the example directory as test targets. Signed-off-by: Taiga Nakayama <dora@dora-gt.jp>
dora-gt
force-pushed
the
feature/dx/testable-md
branch
from
67db0ef
to
9811824
Compare
|
I'm merging this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of #198
I'm breaking the issue down into separate PRs this time.
What this PR realizes is to make
.mds testable but it is NOT automated yet.Integrating into CircleCI would be later.
run-md-test.shto test markdowns.run-md-test.shinjectshook_before_killfunctions into the script of markdowns.scripts/run-md-tests/examples.hook_before_killfunction..mds testable #198 (comment) is this acceptable? @bstrierun-md-test.shexits with0when it succeeded, and with1when it failed. So integrating this script into CircleCI wouldn't be so hard.In a case of success:
In a case of failure:
