Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testnet docs #370

Merged
merged 3 commits into from
Oct 2, 2019
Merged

Add testnet docs #370

merged 3 commits into from
Oct 2, 2019

Conversation

gakonst
Copy link
Member

@gakonst gakonst commented Oct 2, 2019

As title. Rewords the doc from #314 and uses the ilp-cli instead of manual curl requests.

docs/testnet.md Outdated
docker run -it -e NAME=YOUR_NAME interledgerrs/testnet-bundle
```

The above will configure and run the Interledger node, the ETH & XRP engines, and connect to the testnet. Try making some payments!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should link to the bottom of the page and make it clearer that there are instructions for doing that after

docs/testnet.md Outdated

Testing is an absolute requirement when deploying software. Because of that, the Interledger.rs repository ensures that all its features are thoroughly tested. However, network conditions such as latency and bandwidth are not the same as in the real world when running unit and integration tests. In order to simulate that, we leverage test networks (testnets).

Testnets are networks where the topology is similar to the expected real world network topology, but the funds used are not "real" (i.e. do not hold any real-world value). Succesful testnet runs can greatly increase our confidence in the reliability of our software, before deploying it to mainnet where it will be able to control large amounts of money.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we need this section. The testnet is less about testing our software and more about allowing users to interact with the software and APIs without using real money

docs/testnet.md Outdated
|key|value|
|---|---|
|Username|user_qjex4cfk|
|PassKey|us5w0zt1br4ft|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field now says "token"

Copy link
Member Author

@gakonst gakonst Oct 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bit awkward because the API still uses the old variable names:

https://stage.xpring.io/api/accounts/xrp

{"http_endpoint": "https://rs3.xpring.dev/ilp", "passkey": "172thg05wk77y", "btp_endpoint": "btp+wss://rs3.xpring.dev/ilp/btp", "asset_scale": 9, "node": "rs3.xpring.dev", "asset_code": "XRP", "username": "user_1bpsi536", "payment_pointer": "$rs3.xpring.dev/accounts/user_1bpsi536/spsp"}

https://stage.xpring.io/ilp-testnet-creds
image

We should change the interpreter variable names If the API variable names change https://github.com/interledger-rs/interledger-rs/blob/dbe15247478d9ee6dfbef3127488441fd130d66d/crates/ilp-cli/src/interpreter.rs#L335

docs/testnet.md Outdated

```bash
curl \
-H "Authorization: Bearer ${Username}:${PassKey}" \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no longer passkey

docs/testnet.md Show resolved Hide resolved
docs/testnet.md Outdated

You should now be able to send and receive payments through the testnet node.

## Try Out Payments
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Somewhere in here we should show how to get access to the ilp-cli

Copy link
Member

@emschwartz emschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm gonna approve this so you can merge it whenever you think it's ready. I need to go to sleep now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants