feat(stream): sender refactor with rate enforcement #616
Conversation
kincaidoneil
force-pushed
the
ko-stream-rates
branch
4 times, most recently
from
c740d7c
to
958c80d
Compare
crates/interledger-stream/src/lib.rs
Outdated
| assert!( | ||
| match result { | ||
| Err(Error::SendMoneyError(_)) => true, | ||
| _ => false, | ||
| }, |
There was a problem hiding this comment.
nit: You could just do let err = send_money(...).await.unwrap_err(), and then check that the error is the expected one
There was a problem hiding this comment.
I couldn't find an idiomatic way to compare enum variants without a match? And then it's kinda awkward to translate that into an assertion
| PaymentEvent::MaxInFlight => { | ||
| // Wait for 100ms for any request to complete, otherwise try running loop again | ||
| // to see if we reached the timeout since last fulfill | ||
| let fut = timeout( |
There was a problem hiding this comment.
technically since you called await on this, it's no longer a future but the inner result. It might be useful to make this timeout be an exponential backoff or grow in some way? Maybe add a TODO if you think it'd be useful, otherwise leave as is
There was a problem hiding this comment.
Updated this so it calculates the deadline (last fulfill timestamp + max duration since last fulfill), then waits for any request to complete or reach the deadline before running the loop again, which should timeout the payment.
Co-Authored-By: Georgios Konstantopoulos <me@gakonst.com>
kincaidoneil
force-pushed
the
ko-stream-rates
branch
from
f17616f
to
70fcb21
Compare
Big things
interledger-ratescrateLittle things
/paymentsendpoint (percentage of calculated exchange rate which is acceptable to deliver)