RFC-4: Replace account with from/to #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the ledger plugin API to use from/to fields instead of the ambiguous `account` field. To illustrate how the previous API was confusing: In plugin-bells, we actually populated the `account` field for incoming transfers with the sending account, while we populated the `account` field for incoming messages with the receiving (`to`) account. Providing both sending and receiving accounts for both transfers and messages allows us to more closely mirror the underlying API and reduce the potential for confusion.
justmoon
force-pushed
the
feat/st-from-to
branch
from
04ab5dc to
6075455
Compare
justmoon
changed the title
sentientwaffle
approved these changes
Jan 23, 2017
emschwartz
approved these changes
Jan 25, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the ledger plugin API to use from/to fields instead of the
ambiguous
accountfield.To illustrate how the previous API was confusing: In plugin-bells, we
actually populated the
accountfield for incoming transfers with thesending account, while we populated the
accountfield for incomingmessages with the receiving (
to) account.Providing both sending and receiving accounts for both transfers and
messages allows us to more closely mirror the underlying API and reduce
the potential for confusion.