-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various issues with installation of CamCHILDMine #17
Open
martinburchell
wants to merge
62
commits into
intermine:master
Choose a base branch
from
ucam-department-of-psychiatry:docker-fix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix various issues with installation of CamCHILDMine #17
martinburchell
wants to merge
62
commits into
intermine:master
from
ucam-department-of-psychiatry:docker-fix
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are getting truncated
Not the permanent solution. This should be ignored if biotestmine is not being used
There are permissions problems if we try to use a different user
Don't try to do anything with the Solr UID/GID
cargoDeployRemote fails if run for a second time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the process of getting the 2022 FAIR TREATMENT (CamCHILDMine) demo working I ended up making these changes. In summary:
version
from docker compose YAML filesbuild.sh
if any part of the script fails unexpectedly.env
filemalaria-data.tar.gz
if it is not presentgradlew cargoDeployRemote
. In CamCHILDMine I've implemented the workaround described in Gradle needs to start or deploy a second time to serve webapp intermine#2162 (comment)local.docker-compose.yml
. I've removed the parsing of the YAML file inmkdatadirs.sh
as this seemed like a brittle approach and made this script runnable from anywhere.There was a bit of guesswork involved so I'd appreciate another set of eyes on this.