Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basic latest featured #438

Merged
merged 1 commit into from
Apr 7, 2020
Merged

basic latest featured #438

merged 1 commit into from
Apr 7, 2020

Conversation

4www
Copy link
Contributor

@4www 4www commented Apr 2, 2020

Right now on https://radio4000.com/about it is showing all radios.

Thinking this is simpler, but we're still extending ChannelsIndexRoute, where I override the model, so that is actually unneded.

@@ -4,6 +4,10 @@ import ChannelsIndexRoute from 'radio4000/channels/index/route'

export default ChannelsIndexRoute.extend({
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here either:

  • just a normal route
  • or do not rewrite the model hook

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote 2, so it's not just "latest featured" but random like on the homepage. But both work of course :]

@oskarrough
Copy link
Member

Huh, wondering since when is the about page showing all radios…

@4www 4www merged commit 3d0ed11 into master Apr 7, 2020
@4www 4www deleted the fix/about-radios branch April 7, 2020 06:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants