Downgrade core-js to fix esm.sh build issue #1207
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1205
This was a strange issue.
So core-js in commit zloirock/core-js@25e9373 changed some code from
typeof global.process
totypeof process
. Unfortunately this resulted in some part of esm.sh when transpiling for deno to think that the node libraryprocess
needed to be imported. You can see it on the first line here: https://esm.sh/v130/@internetarchive/bookreader@5.0.0-64/deno/BookReader/BookReader.js .So for now rollback core-js to the previous version before this change was introduced. Not sure where the bug lies here ; whether this is an issue with core-js or esm.sh . But this is the quickest way for us to unblock our deploy flow to archive.org
Created an issue on core-js at least: zloirock/core-js#1277