Introduce BookReaderPlugin abstraction and apply to ArchiveAnalyticsPlugin #1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1371 +/- ##
==========================================
+ Coverage 69.24% 69.25% +0.01%
==========================================
Files 59 60 +1
Lines 5108 5133 +25
Branches 1082 1086 +4
==========================================
+ Hits 3537 3555 +18
- Misses 1544 1549 +5
- Partials 27 29 +2 ☔ View full report in Codecov by Sentry. |
cdrini
force-pushed
the
refactor/br-plugin
branch
from
a7b8dd3 to
8eebff9
Compare
cdrini
changed the title
jbuckner
approved these changes
Jan 30, 2025
cdrini
force-pushed
the
refactor/br-plugin
branch
from
561f5c8 to
83c71e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.