Make TextSelectionPlugin extend new BookReaderPlugin class #1372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
refactor/textsel-br-plugin
branch
from
59888e5 to
136b065
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1372 +/- ##
==========================================
- Coverage 69.25% 69.25% -0.01%
==========================================
Files 60 60
Lines 5133 5135 +2
Branches 1086 1087 +1
==========================================
+ Hits 3555 3556 +1
- Misses 1549 1550 +1
Partials 29 29 ☔ View full report in Codecov by Sentry. |
cdrini
force-pushed
the
refactor/textsel-br-plugin
branch
from
136b065 to
b7fb64f
Compare
jbuckner
reviewed
Jan 30, 2025
| } | ||
| window.BookReader = BookreaderWithTextSelection; | ||
| export default BookreaderWithTextSelection; | ||
| BookReader?.registerPlugin('textSelection', TextSelectionPlugin); |
jbuckner
approved these changes
Jan 30, 2025
cdrini
force-pushed
the
refactor/textsel-br-plugin
branch
from
b7fb64f to
0302648
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.