Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate AutoplayPlugin to BookReaderPlugin #1374

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

cdrini
Copy link
Contributor

@cdrini cdrini commented Jan 30, 2025

Testing:

Breaking changes:

  • Moves the root autoplay bookreader methods/fields autoToggle, autoTimer, autoStop to br._plugins.autoplay as toggle, timer, stop
  • Moves the root autoplay options flipDelay, enableAutoPlayPlugin out of the root options to options.plugins.autoplay as flipDelay and enabled.

New features:

  • Adds new option for autoplay plugin, urlParams, defaulting to true. When true, autoflip=1, flipSpeed=<number> and flipDelay=<number> will be read from the url to configure the autoplay plugin.

Copy link

codecov bot commented Jan 30, 2025

Codecov Report

Attention: Patch coverage is 69.44444% with 22 lines in your changes missing coverage. Please review.

Project coverage is 69.21%. Comparing base (c067962) to head (0b79820).

Files with missing lines Patch % Lines
src/plugins/plugin.autoplay.js 70.83% 14 Missing ⚠️
src/BookReader.js 68.75% 5 Missing ⚠️
src/BookReader/Mode2UpLit.js 0.00% 2 Missing ⚠️
src/plugins/url/plugin.url.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1374      +/-   ##
==========================================
- Coverage   69.25%   69.21%   -0.04%     
==========================================
  Files          60       60              
  Lines        5135     5146      +11     
  Branches     1087     1101      +14     
==========================================
+ Hits         3556     3562       +6     
- Misses       1550     1555       +5     
  Partials       29       29              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini force-pushed the refactor/autoplay-br-plugin branch from 91d2986 to 113f59e Compare January 30, 2025 20:25
@cdrini cdrini force-pushed the refactor/autoplay-br-plugin branch from 113f59e to f6bbd87 Compare January 30, 2025 20:28
@cdrini cdrini marked this pull request as ready for review January 30, 2025 23:05
@cdrini cdrini force-pushed the refactor/autoplay-br-plugin branch from 552ea54 to 0b79820 Compare February 1, 2025 01:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant