Fix for ServerNotModified WARC revisit records incorrectly record WARC-Payload-Digest #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refer that functionality to the relevant revisit profile classes.
The previous capture may also have been a 304 but there must be an original 200 capture at the start. This assumption may fail when using an index generated by a version of Heritrix without this fix. But even then you should be no worse off than before.
nlevitt
added a commit
that referenced
this pull request
Mar 23, 2015
Fix for ServerNotModified WARC revisit records incorrectly record WARC-Payload-Digest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue: https://webarchive.jira.com/browse/HER-2080
Also adds crawl.log annotations for server-not-modified duplicates.
Relates to: iipc/openwayback#224