-
Notifications
You must be signed in to change notification settings - Fork 763
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
switch to httpcomponents, get rid of archive-overlay-commons-httpclient #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… This commit also gets rid of most egregious commons-httpclient-specific code in CrawlURI
…e end of http headers. is there a problem with not buffering at this level?
…for SessionInputBuffer; refactor helper classes into their own file RecordingHttpClient.java
…HTTP does, and also avoids sending weird Cookie2:$Version1
…se stuff from modules/
Conflicts: .classpath
…can't rely on stopping right after the headers, which is an assumption of readFullyOrUntil()
Conflicts: .classpath
… httpclient (restore functionality from fcece02 to work with current httpcomponents
Conflicts: commons/src/main/java/org/apache/commons/httpclient/HttpParser.java engine/pom.xml modules/src/main/java/org/archive/modules/CrawlURI.java modules/src/main/java/org/archive/modules/deciderules/MatchesStatusCodeDecideRule.java modules/src/main/java/org/archive/modules/deciderules/NotMatchesStatusCodeDecideRule.java modules/src/main/java/org/archive/modules/fetcher/FetchHTTP.java
…mTest.testReadFullyOrUntil() test passes (how does this pass on master?)
Conflicts: commons/pom.xml commons/src/main/java/org/archive/io/RecordingInputStream.java commons/src/main/java/org/archive/io/RecordingOutputStream.java commons/src/main/java/org/archive/io/ReplayInputStream.java dist/pom.xml engine/pom.xml modules/pom.xml modules/src/main/java/org/archive/modules/extractor/ExtractorHTTP.java modules/src/main/java/org/archive/modules/recrawl/FetchHistoryProcessor.java pom.xml
…rder tries to auto-detect
…stead of specifying it explicitly
kngenie
added a commit
that referenced
this pull request
Jan 14, 2014
switch to httpcomponents, get rid of archive-overlay-commons-httpclient
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.