Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oops, update test to expect post data as url-encoded query string #54

Merged
merged 1 commit into from
Apr 1, 2014
Merged

oops, update test to expect post data as url-encoded query string #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions modules/src/test/java/org/archive/modules/forms/FormLoginProcessorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,10 @@

import static org.archive.modules.CoreAttributeConstants.A_WARC_RESPONSE_HEADERS;

import org.apache.commons.httpclient.NameValuePair;
import org.apache.commons.httpclient.util.EncodingUtil;
import org.archive.modules.CoreAttributeConstants;
import org.archive.modules.CrawlURI;
import org.archive.modules.ProcessorTestBase;
import org.archive.modules.CrawlURI.FetchType;
import org.archive.modules.forms.FormLoginProcessor;
import org.archive.modules.ProcessorTestBase;

public class FormLoginProcessorTest extends ProcessorTestBase {

Expand Down Expand Up @@ -69,8 +66,7 @@ public void testFormLogin() throws Exception {
CrawlURI submitCuri = curi.getOutCandidates().toArray(new CrawlURI[0])[0];
assertEquals("http://example.com/login", submitCuri.toString());
assertEquals(FetchType.HTTP_POST, submitCuri.getFetchType());
NameValuePair[] queryParams = (NameValuePair[]) submitCuri.getData().get(CoreAttributeConstants.A_SUBMIT_DATA);
String queryString = EncodingUtil.formUrlEncode(queryParams, "UTF-8");
String queryString = (String) submitCuri.getData().get(CoreAttributeConstants.A_SUBMIT_DATA);
assertEquals("username-form-field=jdoe&password-form-field=********", queryString);
}
}