Prioritize macros above other inline patterns #223
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: internetarchive/openlibrary#9036
Problem:
Currently, including an inline pattern within a macro breaks the whole process; this is untenable, since it means that escaping a character in an argument renders it wholly unworkable.
Solution:
This fix places macros at the beginning of the list of inline patterns, prioritizing them above inline patterns. This has no effect on anything outside of macros, so there should be no negative side effects. Breaking up the
{{function()}}
pattern into\{\{function()\}\}
still allows for the code to be typed, but not executed.Testing:
Play around with the macros in a custom page. In the live version, escaping a character within the arguments prevents it from working, but it should be functional now.