-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added contributors field to import schema #392
Conversation
Thank you @Billa05! I'll let @cdrini comment too, but I think we could also remove the original |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! A few changes.
Can you also try validating this? Maybe using a site like https://www.jsonschemavalidator.net/ just to make sure we have all the syntax right! :)
@hornc Let's label it as deprecated I think instead of removing it entirely, and place it at the bottom of the doc. The endpoint does still accept this field, so I think it's useful documentation to note that! See https://json-schema.org/draft/2019-09/json-schema-validation#rfc.section.9.3 |
1b9d3cf
to
deecd2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm! Tested on https://www.jsonschemavalidator.net/ and it worked correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DE PAUL
This PR closes #8718
from open library repo.
Description:
Added missing
contributors
field to import schema@cdrini