Fixed edition-header h3 spacing (#4393)

Fixed edition-header h3 spacing by introducing a edition-header class to replace the generic h3 rule which was clashing with the list-header class.
internetarchive · Jan 10, 2021 · 10a05f7 · 10a05f7
1 parent 26fd7e4
commit 10a05f7
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/openlibrary/templates/type/edition/view.html b/openlibrary/templates/type/edition/view.html
@@ -339,13 +339,13 @@ <h3>
           <hr>  
           $if edition.first_sentence:
             <div>
-            <h3 class="collapse">$_("First Sentence")</h3>
+            <h3 class="edition-header">$_("First Sentence")</h3>
             <p>"$(edition.first_sentence)"</p>
             </div>
 
           $if edition.description:
             <div class="section">
-              <h3>$_("Edition Description")</h3>
+              <h3 class="edition-header">$_("Edition Description")</h3>
               <div class="edition-description">
                 <div class="addReadMore showlesscontent">
                   $:sanitize(format(edition.description))
@@ -360,7 +360,7 @@ <h3>$_("Edition Description")</h3>
 
           $if edition.notes or edition.series or edition.volume or edition.genres or edition.other_titles or edition.copyright_date or edition.translation_of or edition.translated_from:
             <div class="section">
-                <h3>$_("Edition Notes")
+                <h3 class="edition-header">$_("Edition Notes")
                 </h3>
                 $if edition.notes:
                     $:format(edition.notes)
@@ -403,7 +403,7 @@ <h3 class="header">
           $ contributors = edition.get('contributors', [])
           $if contributors:
             <div class="section">
-              <h3 class="collapse">$_("Contributors")</h3>
+              <h3 class="edition-header">$_("Contributors")</h3>
               <dl class="meta">
               $for c in contributors:
                     $:display_value(c.role, c.name)

diff --git a/static/css/components/work.less b/static/css/components/work.less
@@ -29,11 +29,6 @@
 // Center (editionAbout)
 div.editionAbout {
   margin-bottom: 20px;
-  h3 {
-    font-size: 14px;
-    margin: 0 0 0em;
-  }
-
   p {
     margin: 1em 0;
     font-size: 13px;
@@ -96,6 +91,11 @@ vertical-align: middle;
   font-size: .8em;
 }
 
+h3.edition-header {
+  font-size: 14px;
+  margin: 0 0 0em;
+}
+
 h2.edition-byline {
   margin: 7px 2px 20px;
 }