Merge pull request #9874 from evanastevska/h6-to-h3

Changed h6 to h3 in subject tags for better accessibility, and updated CSS
internetarchive · Sep 17, 2024 · 97c252d · 97c252d
2 parents 16120e0 + 0d30cd4
commit 97c252d
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/openlibrary/macros/RelatedSubjects.html b/openlibrary/macros/RelatedSubjects.html
@@ -17,6 +17,6 @@ <h2>$_("Related...")</h2>
 
 $for category, label, limit in subject_list:
     <div class="contentQuarter link-box link-box--with-header">
-      <h6 class="black collapse uppercase">$label</h6>
+      <h3 class="black collapse uppercase">$label</h3>
       $:renderSubjects(page[category][:limit])
     </div>
diff --git a/openlibrary/macros/SubjectTags.html b/openlibrary/macros/SubjectTags.html
@@ -4,7 +4,7 @@
   $if subjects:
     <div class="section link-box">
       <span class="clamp" data-before="&#9656; ">
-      <h6>$label</h6>
+      <h3>$label</h3>
         $for subject in subjects:
           <a href="/subjects/$prefix$utf8(subject.lower().replace(' ', '_').replace(',', '').replace('/', ''))" data-ol-link-track="$track_value">$subject</a>$cond(not loop.last, ",", "")
       </span>

diff --git a/openlibrary/templates/publishers/view.html b/openlibrary/templates/publishers/view.html
@@ -61,7 +61,7 @@ <h2>$_("Common Subjects")
 
     $for s, limit in subject_list:
         <div class="contentQuarter link-box link-box--with-header">
-            <h6>$s</h6>
+            <h3>$s</h3>
             $:renderSubjects(page[s][:limit])
         </div>
         $if s != 'times':

diff --git a/openlibrary/templates/type/author/view.html b/openlibrary/templates/type/author/view.html
@@ -157,7 +157,7 @@ <h2 class="collapse">
         $def render_subjects(label, subjects, prefix):
             $if subjects:
                 <div class="section link-box link-box--with-header">
-                    <h6 class="collapse black uppercase">$label</h6>
+                    <h3 class="collapse black uppercase">$label</h3>
                     $for _, subject, count in subjects:
                         <a itemprop="knowsAbout" href="/subjects/$prefix$subject.lower().replace(' ', '_')">$subject</a>$cond(not loop.last, ",", "")
                 </div>

diff --git a/static/css/components/link-box.less b/static/css/components/link-box.less
@@ -7,7 +7,7 @@
   white-space: normal;
   word-wrap: break-word;
 
-  h6 {
+  h3 {
     color: @grey;
     margin: 0;
     padding: 0;
@@ -16,7 +16,7 @@
     font-size: @font-size-label-medium;
   }
 
-  &.link-box--with-header h6 {
+  &.link-box--with-header h3 {
     display: block;
   }
 }