Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea on generic edit pages should be full width #10058

Closed
cdrini opened this issue Nov 21, 2024 · 5 comments · Fixed by #10137
Closed

Textarea on generic edit pages should be full width #10058

cdrini opened this issue Nov 21, 2024 · 5 comments · Fixed by #10137
Assignees
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 21, 2024

Problem

image

Reproducing the bug

  1. Login & go to your profile page by clicking the hamburger icon and selecting "My Profile"
  2. Click Edit
  • Expected behavior: The text area is full width
  • Actual behavior: The text area only fills half the screen

Context

  • Browser (Chrome, Safari, Firefox, etc): FF
  • OS (Windows, Mac, etc): Win
  • Logged in (Y/N): Y
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders


Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@cdrini cdrini added Type: Bug Something isn't working. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] labels Nov 21, 2024
@lee14334
Copy link
Contributor

Hi @RayBB, would it be alright if I took up this issue?

@yunjia1
Copy link

yunjia1 commented Nov 21, 2024

Hi @RayBB, could I help with this issue? It is my first time contributing to open-source so this seems like a great project to start with!

@RayBB
Copy link
Collaborator

RayBB commented Nov 21, 2024

@lee14334 and @yunjia1 can you please both confirm you've read the CONTRIBUTING.md and are ready to start working on this project?

@lee14334 if so, let me know soon and I'll assign you to this issue.

@yunjia1 as you can see, @lee14334 already asked to work on this, so we will give them a few days to respond. If not, then you can work on it. Feel free to look into the issue and see how you'd do it even if Lee does as it's a great learning opporunity.

Thanks both

@lee14334
Copy link
Contributor

Hi @RayBB, I’ve gone through the CONTRIBUTING.md and am ready to take on the issue. Please assign it to me when you can. Thanks for coordinating!

@RayBB
Copy link
Collaborator

RayBB commented Nov 22, 2024

@lee14334 you're assigned now. Good luck!

@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Good First Issue Easy issue. Good for newcomers. [managed] Lead: @RayBB Issues overseen by Ray (Onboarding & Documentation Lead) [manages] Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants