Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make textarea on edit pages full width #10137

Merged

Conversation

lee14334
Copy link
Contributor

@lee14334 lee14334 commented Dec 9, 2024

Closes #10058

This PR addresses a bug where the text area in the edit page was expected to be full width, but actually filled only half of it instead due to the conflicting textarea style defined in the component forms.olform.less.

Technical

This change increases the specificity of the textarea element in edit-pages.less by adding a class selector, ensuring that the text area for the edit page follows the style from page-edit.less.

Testing

  1. Login & go to your profile page by clicking the hamburger icon and selecting "My Profile"
  2. Click Edit
  3. Scroll to Description section. Expect for the text area to take 100% width as shown in the screenshot.

Screenshot

Before:
before

After:
fix

Stakeholders

@RayBB

Copy link
Collaborator

@RayBB RayBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working for me. Great work!
Don't think this is too risky but did check on author/book edit pages and they still seemed fine.

Now we need @cdrini to check it out.

@RayBB RayBB assigned cdrini and unassigned RayBB Dec 10, 2024
@RayBB RayBB added the Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this. label Dec 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 17.44%. Comparing base (347bff9) to head (3025f5d).
Report is 168 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10137      +/-   ##
==========================================
+ Coverage   17.12%   17.44%   +0.31%     
==========================================
  Files          89       89              
  Lines        4752     4792      +40     
  Branches      831      848      +17     
==========================================
+ Hits          814      836      +22     
- Misses       3428     3436       +8     
- Partials      510      520      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini assigned RayBB and unassigned cdrini Dec 11, 2024
@cdrini cdrini merged commit cc339a9 into internetarchive:master Dec 11, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Staff / Internal Reviewed a PR but don't have merge powers? Use this.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Textarea on generic edit pages should be full width
4 participants