Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected language not saved #10126

Closed
seabelis opened this issue Dec 6, 2024 · 0 comments · Fixed by #10127
Closed

Selected language not saved #10126

seabelis opened this issue Dec 6, 2024 · 0 comments · Fixed by #10127
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Affects: UI Issues with the web site's user interface. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]

Comments

@seabelis
Copy link
Collaborator

seabelis commented Dec 6, 2024

Problem

When editing an edition and adding a language, the language is not retained on save.

Reproducing the bug

  1. Go to ...an edition edit form.
  2. Do ...add a language and save.
  • Expected behavior: Language should be saved.
  • Actual behavior: Lanuguage not saved.

Context

  • Browser (Chrome, Safari, Firefox, etc):
  • OS (Windows, Mac, etc):
  • Logged in (Y/N):
  • Environment (prod, dev, local): prod

Breakdown

Requirements Checklist

  • [ ]

Related files

Stakeholders

Instructions for Contributors

  • Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
@seabelis seabelis added Type: Bug Something isn't working. [managed] Affects: UI Issues with the web site's user interface. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Affects: Librarians Issues related to features that librarians particularly need. [managed] Needs: Lead labels Dec 6, 2024
@cdrini cdrini mentioned this issue Dec 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Affects: Librarians Issues related to features that librarians particularly need. [managed] Affects: UI Issues with the web site's user interface. [managed] Needs: Breakdown This big issue needs a checklist or subissues to describe a breakdown of work. [managed] Needs: Lead Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove no longer needed identifier jquery repeat cdrini/openlibrary
1 participant
@seabelis