Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer needed identifier jquery repeat #10127

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

cdrini
Copy link
Collaborator

@cdrini cdrini commented Dec 6, 2024

Closes #10126
Closes #10125

Since this was removed in #10032 , this is triggering an error which is causing issues for downstream JS

Technical

Testing

  • Autocomplete appears for work, language on book edit page
  • Can remove classification rows

Screenshot

Stakeholders

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 17.44%. Comparing base (347bff9) to head (0d82393).
Report is 131 commits behind head on master.

Files with missing lines Patch % Lines
openlibrary/plugins/openlibrary/js/index.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10127      +/-   ##
==========================================
+ Coverage   17.12%   17.44%   +0.31%     
==========================================
  Files          89       89              
  Lines        4752     4792      +40     
  Branches      831      846      +15     
==========================================
+ Hits          814      836      +22     
- Misses       3428     3438      +10     
- Partials      510      518       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cdrini cdrini marked this pull request as ready for review December 6, 2024 21:04
@cdrini cdrini added On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed] labels Dec 6, 2024
@cdrini
Copy link
Collaborator Author

cdrini commented Dec 6, 2024

Auto-merging this one; small high priority change which I want to send out before the weekend since a good chunk of the edit page is not working correctly.

@cdrini cdrini merged commit d1a4947 into internetarchive:master Dec 6, 2024
3 checks passed
@cdrini cdrini deleted the fix-edit-js branch December 6, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On testing.openlibrary.org This PR has been deployed to testing.openlibrary.org for testing Priority: 1 Do this week, receiving emails, time sensitive, . [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Selected language not saved "What work is this an edition of" field no longer populates
2 participants