Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching should support sorting by classifications #3574

Closed
3 of 5 tasks
cdrini opened this issue Jul 13, 2020 · 1 comment · Fixed by #4607
Closed
3 of 5 tasks

Searching should support sorting by classifications #3574

cdrini opened this issue Jul 13, 2020 · 1 comment · Fixed by #4607
Assignees
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Library Explorer Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Jul 13, 2020

Although searches like https://dev.openlibrary.org/search?q=lcc%3AQA*&mode=everything are possible (on dev), it is currently not possible to view the results in "Shelf order". This data lives in solr, but has just not been exposed to any of the OL search apis.

This would be essential for a "Sort by shelf order" feature.

Summary of Requirements

  • Add &sort=lcc parameter to /search and /search.json
  • Add &sort=ddc parameter to /search and /search.json
  • Bonus: When sorting by a classification, display the classification in the search results.
  • Bonus: Include in UI as an option; (Shelf Order (DDC) | Shelf Order (LCC))
  • Bonus: Add GA tracking to all sort options

Note: lcc and ddc are multiValued fields in solr; this makes them ineligible for use as a sorting field. The fields lcc_sort and ddc_sort were created for this purpose, but they had to be single valued (1 per work), and the longed such value was used. This could create a kind of confusing situation where one could back unexpected results. We might want to expose lcc_sort and ddc_sort directly, maybe? Or automatically switch lcc: to lcc_sort if we're sorting? But that will change the number of results :/ Exposing lcc_sort might be better for now.

Stakeholders

@seabelis @LeadSongDog

@cdrini cdrini added Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed] Theme: Search Issues related to search UI and backend. [managed] Priority: 2 Important, as time permits. [managed] Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] labels Jul 13, 2020
@cdrini cdrini added this to the Active Sprint milestone Jul 13, 2020
@cdrini cdrini self-assigned this Jul 13, 2020
@LeadSongDog
Copy link

LeadSongDog commented Jul 13, 2020

It strikes me that these sorts are not necessarily for browse-time. The classifications intrinsically need only to be considered when saving work records, a much less costly thing. A work record could link to prev- and next-LCClass, prev- and next-DDC.

@cdrini cdrini modified the milestones: Active Sprint, Next (proposed) Sep 9, 2020
@cdrini cdrini added Priority: 1 Do this week, receiving emails, time sensitive, . [managed] and removed Priority: 2 Important, as time permits. [managed] labels Sep 9, 2020
@cdrini cdrini modified the milestones: Active Sprint, Next (proposed) Oct 5, 2020
@cdrini cdrini added Priority: 2 Important, as time permits. [managed] and removed Priority: 1 Do this week, receiving emails, time sensitive, . [managed] labels Oct 5, 2020
@cdrini cdrini removed this from the Next (proposed) milestone Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Priority: 2 Important, as time permits. [managed] Theme: Library Explorer Theme: Search Issues related to search UI and backend. [managed] Type: Feature Request Issue describes a feature or enhancement we'd like to implement. [managed]
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants