-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to sort search results by classification, random #4607
Merged
mekarpeles
merged 10 commits into
internetarchive:master
from
cdrini:3574/feature/search-classification-sort
Feb 22, 2021
Merged
Ability to sort search results by classification, random #4607
mekarpeles
merged 10 commits into
internetarchive:master
from
cdrini:3574/feature/search-classification-sort
Feb 22, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdrini
force-pushed
the
3574/feature/search-classification-sort
branch
2 times, most recently
from
February 15, 2021 18:31
d56bcf7
to
721693f
Compare
cdrini
changed the title
Ability to sort search results by classification
Ability to sort search results by classification, title, random
Feb 15, 2021
cdrini
force-pushed
the
3574/feature/search-classification-sort
branch
from
February 15, 2021 18:45
721693f
to
75cd857
Compare
The results are _sort of_ correct, but lots of wrong entries. Not sure why.
cdrini
changed the title
Ability to sort search results by classification, title, random
Ability to sort search results by classification, random
Feb 15, 2021
mekarpeles
approved these changes
Feb 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, tested on staging v. prod
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3574
Adds ability to sort by lcc/ddc to /search and /search.json
Technical
ddc_sort
/lcc_sort
fields, because solr does not support sorting on multi-valued fields, which is whatddc
andlcc
are. This does mean that some things will appear out of order when doing e.g.ddc:8*
sorted byddc_sort
. So I also exposedddc_sort
as a search field we can use -- although this has the caveat that some works will be missing.sort=random_my_seed
to get a new random.Testing
Title sorting worksNot reallyScreenshot
Stakeholders