Use definition table for contributors on Books Page #3713
Assignees
Labels
Lead: @jdlrobson
Issues overseen by Jon (Front-end Lead) [managed]
Module: Books Page
Priority: 3
Issues that we can consider at our leisure. [managed]
Theme: Design
Issues related to UI design, branding, etc. [managed]
Type: Feature Request
Issue describes a feature or enhancement we'd like to implement. [managed]
Comments
bitnapper
added
the
Needs: Triage
xayhewalo
added
Good First Issue
xayhewalo
changed the title
xayhewalo
added
Module: Books Page
and removed
Good First Issue
|
@bitnapper Can I work on this? |
Also not in charge... but I think everyone would be very greatful, if you can do something about that. |
|
When somebody is looking into that, maybe the dt element could get a bit more space to avoid overlapping:
|
|
@jdlrobson Hi, |
|
@nynaalekhya fine with me, provided @mekarpeles has no objections. |
Hi, @nynaalekhya. I have solved this issue locally, but as you claimed it first, if you have no problem, can I create a PR for this issue. If you want to solve this issue, I don't have any problem 😄 |
|
@Yashs911 Fine for now, but claim the issue before you work on it. |
|
Thans, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Just a small design request. In the editions #edition-details section, the details like id's, physical details... are styled with definition tables which produces a nicely structured view while the contributors section consists of list elements with lots of breaks which looks very cramped.
Just compare the sections in this example: OL28775995M
Style the contributors section with the same
<dt><dl><dd>elements as the other sections.Sorry that I can't make the change myself but I couldn't find the corresponding file and even than I'm not sure if I know how to change that.
The text was updated successfully, but these errors were encountered: