-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Work Description allows text to extend beyond visual borders of field. #3611
Comments
@jdlrobson Can I work on this issue? |
@nynaalekhya I think focusing on #3713 would be better. This particular issue doesn't look super high priority to me and the description could do with some additional data. @spamspambaconspam could you provide some more information here such as the URI you were using to generate this bug report? I'm unable to replicate it.. |
@jdlrobson Thank you for assigning me the other issues. |
Maybe this could summarized as, Go to https://openlibrary.org/books/OL23764632M/The_Best_Short_Stories_of_1915 > Click on "work details" tab 1st case: The preview text overflows when lengthy sentence is entered |
@nynaalekhya I don't recommend this particular task as I don't actually understand the issue here and want further information. |
@jdlrobson |
@jdlrobson #2597 Is this closed? |
Yep I think any of these issues would be better, but I've not been checking them in a while, so any help working out which are still broken would also be helpful :) https://github.com/internetarchive/openlibrary/issues?q=is%3Aopen+label%3A%22Lead%3A+%40jdlrobson%22+label%3A%22Priority%3A+3%22+-label%3A%22Type%3A+Feature+Request%22 |
@jdlrobson |
While entering data in the WORK DESCRIPTION field:
If lines are numbered, the numbering itself is set outside the border of the field, as if the string is left-aligned by the first alphanum char following the line numbering string.
I can play around with it and get it to stay within the borders, but ONLY if I add a trailing zero.
It seems to be hyper-responsive to typing the digit "1" and a period/decimal char.
Zeroes, twos, etc don't seem to create the same response.
First screenshot is of my numbered list, just as I entered it, with the results previewed.
Second screenshot adds a trailing zero to enforce the constraints.
Third s/shot shows how aggressive it is - it's already numbering the line, just with a zero and decimal.
Fourth s/shot is also kind funky -- I removed the line numbering from my line #2, and it did the following:
it concatenated both lines #1 & #2, and then continued numbering from what WAS line #3.
The line numbering you see in the edit box is MINE, from my plain text paste. It was not generated via markdown.
So it actually removed part of my original string.
I also added a few more screenshots - I was playing around to see what exact sequence of chars would "break" the formatting.
They may help you as clues.
Evidence / Screenshot (if possible)
Relevant url?
This is where I noticed the issue.
I've left the numbering in place, in case you want to see it in prod without having to jump to prod :)
https://openlibrary.org/books/OL23764632M/The_Best_Short_Stories_of_1915
Steps to Reproduce
Start numbering at one.
Details
Proposal & Constraints
Related files
Stakeholders
The text was updated successfully, but these errors were encountered: