Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work Description allows text to extend beyond visual borders of field. #3611

Open
spamspambaconspam opened this issue Jul 21, 2020 · 10 comments
Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Bug Something isn't working. [managed]

Comments

@spamspambaconspam
Copy link

While entering data in the WORK DESCRIPTION field:

If lines are numbered, the numbering itself is set outside the border of the field, as if the string is left-aligned by the first alphanum char following the line numbering string.

I can play around with it and get it to stay within the borders, but ONLY if I add a trailing zero.

It seems to be hyper-responsive to typing the digit "1" and a period/decimal char.
Zeroes, twos, etc don't seem to create the same response.

First screenshot is of my numbered list, just as I entered it, with the results previewed.
Second screenshot adds a trailing zero to enforce the constraints.
Third s/shot shows how aggressive it is - it's already numbering the line, just with a zero and decimal.
Fourth s/shot is also kind funky -- I removed the line numbering from my line #2, and it did the following:
it concatenated both lines #1 & #2, and then continued numbering from what WAS line #3.
The line numbering you see in the edit box is MINE, from my plain text paste. It was not generated via markdown.
So it actually removed part of my original string.

I also added a few more screenshots - I was playing around to see what exact sequence of chars would "break" the formatting.
They may help you as clues.

Evidence / Screenshot (if possible)

image
image
image
image
image
image
image

Relevant url?

This is where I noticed the issue.
I've left the numbering in place, in case you want to see it in prod without having to jump to prod :)

https://openlibrary.org/books/OL23764632M/The_Best_Short_Stories_of_1915

Steps to Reproduce

Start numbering at one.

Details

  • Logged in (Y/N)? Yessir
  • Browser type/version? Edge
  • Operating system? Win 10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@spamspambaconspam spamspambaconspam added Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Type: Bug Something isn't working. [managed] labels Jul 21, 2020
@xayhewalo xayhewalo added Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jul 26, 2020
@nynaalekhya
Copy link
Contributor

@jdlrobson Can I work on this issue?

@jdlrobson jdlrobson added Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] and removed Priority: 3 Issues that we can consider at our leisure. [managed] labels Jan 7, 2021
@jdlrobson
Copy link
Collaborator

jdlrobson commented Jan 7, 2021

@nynaalekhya I think focusing on #3713 would be better. This particular issue doesn't look super high priority to me and the description could do with some additional data.

@spamspambaconspam could you provide some more information here such as the URI you were using to generate this bug report? I'm unable to replicate it..

@nynaalekhya
Copy link
Contributor

@jdlrobson Thank you for assigning me the other issues.
But since the issues have already been worked on by someone else, can I take up this one?

@nynaalekhya
Copy link
Contributor

Maybe this could summarized as,

Go to https://openlibrary.org/books/OL23764632M/The_Best_Short_Stories_of_1915 > Click on "work details" tab

1st case: The preview text overflows when lengthy sentence is entered

cap3

@jdlrobson
Copy link
Collaborator

jdlrobson commented Jan 7, 2021

@nynaalekhya I don't recommend this particular task as I don't actually understand the issue here and want further information.

@nynaalekhya
Copy link
Contributor

2nd case: Enter 01. and enter spacebar twice in "How would you describe book" textbox to reproduce the following,

Input:

cap1

Output:

cap2

@nynaalekhya
Copy link
Contributor

@nynaalekhya I don't recommend this particular task as I don't actually understand the issue here and want further information. How about #2597 ?

@jdlrobson
Yeah sure, I will take up that issue.
Thank you

@nynaalekhya
Copy link
Contributor

@jdlrobson #2597 Is this closed?

@jdlrobson
Copy link
Collaborator

Yep I think any of these issues would be better, but I've not been checking them in a while, so any help working out which are still broken would also be helpful :) https://github.com/internetarchive/openlibrary/issues?q=is%3Aopen+label%3A%22Lead%3A+%40jdlrobson%22+label%3A%22Priority%3A+3%22+-label%3A%22Type%3A+Feature+Request%22

@nynaalekhya
Copy link
Contributor

@jdlrobson
Certainly! Thank you.

@jdlrobson jdlrobson added Priority: 3 Issues that we can consider at our leisure. [managed] and removed Priority: 4 An issue, but should be worked on when no other pressing work can be done. [managed] labels May 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Theme: Editing Issues related to the user editing/wiki editing experience. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Development

No branches or pull requests

4 participants