Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edition page, tablet mode: Include full-width want-to-read + add read button #2597

Closed
mekarpeles opened this issue Nov 1, 2019 · 2 comments
Closed

Edition page, tablet mode: Include full-width want-to-read + add read button #2597

mekarpeles opened this issue Nov 1, 2019 · 2 comments
Assignees
@jdlrobson
Labels
Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]

Comments

@mekarpeles
Copy link
Member

mekarpeles commented Nov 1, 2019 •
edited
Loading

The UI looks a bit funky in tablet mode (looks good in mobile / desktop). We should probably show both the read button and the full-width want-to-read button in this tablet mode.

@jdlrobson @cecyc do you think this should be a followup issue or fixed in this branch? I'm supportive of either.

Today:
dev openlibrary org_books_OL25930651M_The_Three-Body_Problem (1)

Should be
image

Originally posted by @mekarpeles in #2596 (comment)
@xayhewalo xayhewalo added Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 3 Issues that we can consider at our leisure. [managed] State: Backlogged Type: Bug Something isn't working. [managed] labels Nov 14, 2019
@xayhewalo
Copy link
Collaborator

Assigning jdlrobon (not tagging per request) per slack discussions

@xayhewalo xayhewalo added Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] and removed Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Dec 24, 2019
@jdlrobson jdlrobson mentioned this issue Jan 7, 2021
Open
@jdlrobson
Copy link
Collaborator

@mekarpeles I think we hid lists in the new redesign and this is not relevant any more so closing this out. Please reopen if I'm wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdlrobson jdlrobson

Labels
Affects: Mobile/Responsive Affects the responsive UI on mobile devices. [managed] Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 3 Issues that we can consider at our leisure. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jdlrobson @mekarpeles @xayhewalo