Consistency of borrow and want to read buttons on mobile on books page #2596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The UI looks a bit funky in tablet mode (looks good in mobile / desktop). We should probably show both the read button and the full-width want-to-read button in this tablet mode. @jdlrobson @cecyc do you think this should be a followup issue or fixed in this branch? I'm supportive of either.
|
|
Otherwise, LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow ups to #2586
While reviewing #2586 I noticed some design inconsistencies on mobile and code we can remove!
cc @mekarpeles
Before:
After:
Technical
Testing
Visit the local url equivalent of https://openlibrary.org/books/OL25930651M/The_Three-Body_Problem
Evidence