catalog/onix/onix.py attempts to use a global variable in init(), but doesn't declare it global

[bowlofeggs]

onix_codelists and onix_shortnames are both initialized to None. Later in the module loading, init() gets called, which attempts to set them to useful dictionaries. Because they aren't declared global in init(), new variables are created within init() that exist only within the scope of that method. The fix is to add these lines to the top of init():

global onix_codelists
global onix_shortnames

I've forked the project and intend to make a push that will fix this issue soon. I'll post back here with the revision that you can pull to get the fix. Thanks!

[bowlofeggs]

I've fixed this in my fork: http://github.com/rbarlow/openlibrary/commit/a892f5a35f727587b1e1cae9210a8a0882da9ea3

[bencomp]

Perhaps should do a pull request? :)

[sbshah97]

@mekarpeles I think we should close this!