Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n files not built automatically on Python 3 web nodes #4040

Closed
cdrini opened this issue Nov 6, 2020 · 5 comments · Fixed by #4042
Closed

i18n files not built automatically on Python 3 web nodes #4040

cdrini opened this issue Nov 6, 2020 · 5 comments · Fixed by #4042
Assignees
@cdrini
Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Type: Bug Something isn't working. [managed]

Comments

@cdrini
Copy link
Collaborator

cdrini commented Nov 6, 2020

Steps to Reproduce

  1. Go to https://openlibrary.org/books/OL25428864M/Americanah?lang=fr

Details

  • Logged in (Y/N)? Y
  • Browser type/version? FF82
  • Operating system? Win10
  • Environment (prod/dev/local)? prod

Proposal & Constraints

Related files

Stakeholders

@cclauss
@cdrini cdrini added Type: Bug Something isn't working. [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Theme: Upgrade to Python 3 Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] labels Nov 6, 2020
@jimchamp
Copy link
Collaborator

jimchamp commented Nov 6, 2020 •
edited
Loading

Dates are being translated, so the issue may lie in our i18n compilation process:
i18n_issue_fr

Is there an .mo file in openlibrary/i18n/fr? If not, try running make i18n and check for errors.

@cdrini
Copy link
Collaborator Author

cdrini commented Nov 6, 2020

👍 That looks like it; make i18n looks like it wasn't run at all :/ Dropping in priority

@cdrini cdrini added Priority: 1 Do this week, receiving emails, time sensitive, . [managed] and removed Priority: 0 Fix now: Issue prevents users from using the site or active data corruption. [managed] labels Nov 6, 2020
@cdrini
Copy link
Collaborator Author

cdrini commented Nov 6, 2020 •
edited
Loading

I ran it manually, and it's working now 🎉 but we have to figure out why this wasn't run automatically during the build process

@cdrini cdrini changed the title Internationalization not working on Python 3 i18n files not built automatically on Python 3 web nodes Nov 6, 2020
@cclauss
Copy link
Contributor

cclauss commented Nov 6, 2020

#3906 (review)
#2253

@cclauss cclauss mentioned this issue Nov 6, 2020
Merged
@cdrini
Copy link
Collaborator Author

cdrini commented Nov 6, 2020

False alarm; I'm going to assign this one to myself. It was a docker issue, not a code issue.

@cdrini cdrini assigned cdrini and unassigned cclauss Nov 6, 2020
@cdrini cdrini added Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] and removed CH: unicode Lead: @cclauss Issues overseen by Chris (Python3 & Dev-ops lead 2019-2021) [managed] labels Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cdrini cdrini

Labels
Lead: @cdrini Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed] Module: Docker Issues related to the configuration or use of Docker. [managed] Priority: 1 Do this week, receiving emails, time sensitive, . [managed] Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Type: Bug Something isn't working. [managed]
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

from openlibrary.i18n import gettext as _
3 participants
@cclauss @cdrini @jimchamp