Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

from openlibrary.i18n import gettext as _ #4042

Merged
merged 1 commit into from
Nov 7, 2020
Merged

from openlibrary.i18n import gettext as _ #4042

merged 1 commit into from
Nov 7, 2020

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Nov 6, 2020

Closes #4040

Reverts a change made in #3906 (review) to reenable our internationalization of strings.

Technical

Testing

Screenshot

Stakeholders

@cclauss cclauss added Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed] Theme: Upgrade to Python 3 labels Nov 6, 2020
@cclauss cclauss added this to the Active Sprint milestone Nov 6, 2020
@cclauss cclauss requested review from cdrini and mekarpeles November 6, 2020 19:31
@mekarpeles mekarpeles merged commit b61476d into internetarchive:master Nov 7, 2020
@cclauss cclauss deleted the import-gettext-as-_ branch November 7, 2020 22:23
@mekarpeles mekarpeles added python Pull requests that update Python code and removed Module: Python labels Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code Theme: Internationalization Making OpenLibrary work for both foreign-language users and books. [managed]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n files not built automatically on Python 3 web nodes
2 participants