Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML validator issues on books page #4440

Closed
jdlrobson opened this issue Jan 20, 2021 · 4 comments · Fixed by #4445
Closed

Fix HTML validator issues on books page #4440

jdlrobson opened this issue Jan 20, 2021 · 4 comments · Fixed by #4445
Assignees
@SaravgiYash
Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] validation

Comments

@jdlrobson
Copy link
Collaborator

Incorrect HTML can lead to rendering issues and bugs.

Evidence / Screenshot (if possible)

The validator tool flags errors on https://validator.w3.org/nu/?doc=https%3A%2F%2Fopenlibrary.org%2Fbooks%2FOL28775995M%2FDer_Todeskanal/Der_Todeskanal

Steps to Reproduce

  1. Run docker-compose exec web bash
  2. Run `python ./scripts/copydocs.py "/books/OL28775995M"
  3. Use the validator tools direct input feature to flag errors
  4. fix errors in the associated templates
  5. submit a pull request addressing the issues.

Stakeholders

@jdlrobson
@jdlrobson jdlrobson added Type: Bug Something isn't working. [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] labels Jan 20, 2021
@jdlrobson jdlrobson mentioned this issue Jan 20, 2021
Closed
47 tasks
@jdlrobson jdlrobson added Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Priority: 2 Important, as time permits. [managed] labels Jan 20, 2021
@SaravgiYash
Copy link
Contributor

@jdlrobson I would like to work on this issue.
image
I think in the URL, you have added Der_Todeskanal two times

@SaravgiYash
Copy link
Contributor

@jdlrobson
image
1st error: replacing space with %20 (encoding the URL) will solve this error
2nd error: I don't think we can do anything about it? Or can we?
3rd error: Already Fixed

@jdlrobson
Copy link
Collaborator Author

@jdlrobson I would like to work on this issue.

Sure. All I ask is just to pick one task at a time so that others don't get alienated from contributing.

2nd error: I don't think we can do anything about it? Or can we?

This should be an attribute data-workid, which will require potentially other changes in JS/CSS

@SaravgiYash
Copy link
Contributor

@jdlrobson, I have fixed all the errors. Can you please guide me on how to fix Duplicate ID read_ebook. (4) the same error is also there on the homepage.

@SaravgiYash SaravgiYash mentioned this issue Jan 20, 2021
Merged
@mekarpeles mekarpeles added the Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] label Jan 20, 2021
@mekarpeles mekarpeles mentioned this issue Jan 20, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaravgiYash SaravgiYash

Labels
Lead: @jdlrobson Issues overseen by Jon (Front-end Lead) [managed] Needs: Triage This issue needs triage. The team needs to decide who should own it, what to do, by when. [managed] Priority: 2 Important, as time permits. [managed] Type: Bug Something isn't working. [managed] Type: Subtask of Epic A subtask that is part of the work breakdown of an epic issue (see comments). [managed] validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix validation errors on books page SaravgiYash/openlibrary
3 participants
@jdlrobson @mekarpeles @SaravgiYash